Optmize email normalization #6557
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes email normalization by preventing duplicate calls to the normalize_gmail function. It removes the redundant is_valid_email function and replaces the logic within send_messages to iterate through recipient emails only once, while also adding a test to verify that invalid emails are filtered out.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kitsune/sumo/tests/test_email_utils.py | Added a test case to validate that invalid emails are removed correctly. |
| kitsune/sumo/email_utils.py | Removed the is_valid_email function and refactored send_messages to normalize and validate emails in a single pass. |
| send_messages_mock = mock_mail.get_connection().__enter__().send_messages | ||
| send_messages_mock.assert_called_once_with(messages) | ||
| # Check that the invalid email was removed | ||
| self.assertEqual(messages[0].to, ["valid@example.com", "another.valid@example.com"]) |
There was a problem hiding this comment.
another.valid@example.com is a valid email address. invalid.@example.com is not. The need for the gmail normalization is because for gmail addresses with dots (.) are the same. This is not true for other systems
There was a problem hiding this comment.
FWIW, the original test above did test an invalid email address ("ringo").
Avoids to call the normalzie_gmail function twice